Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow file: for SQLite URIs #2948

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented Jun 1, 2022

The quaint must be merged, then updated here and tests should be run before merging. Do not merge before Prisma 4 is due.

Quaint: prisma/quaint#370
Closes: prisma/prisma#11468

@pimeys pimeys requested a review from a team as a code owner June 1, 2022 10:58
migration-engine/core/src/lib.rs Show resolved Hide resolved
@janpio janpio added this to the 4.0.x milestone Jun 2, 2022
@pimeys pimeys force-pushed the prisma-4/remove-sqlite-provider-from-url branch from d54e7f1 to 0db570f Compare June 8, 2022 08:26
@pimeys pimeys force-pushed the prisma-4/remove-sqlite-provider-from-url branch from 0db570f to 880b0a7 Compare June 8, 2022 08:29
@pimeys pimeys merged commit 24a8694 into main Jun 8, 2022
@pimeys pimeys deleted the prisma-4/remove-sqlite-provider-from-url branch June 8, 2022 15:31
@aradhya-tiwari
Copy link

It would be good if we can use services like s3 with SQLite but restricting SQLite with "file:" stops from doing this.

@Jolg42
Copy link
Member

Jolg42 commented Nov 28, 2022

@AradhyaTiwari Could you open an issue about this? We would be interested to know more details about what's your use-case here. An example would be great 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sqlite: for defining a sqlite url
5 participants