Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent MySQL SET DEFAULT #2957

Closed
wants to merge 1 commit into from
Closed

Prevent MySQL SET DEFAULT #2957

wants to merge 1 commit into from

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented Jun 3, 2022

@pimeys pimeys added this to the 4.0.x milestone Jun 3, 2022
@pimeys pimeys requested a review from a team as a code owner June 3, 2022 09:08
janpio
janpio reviewed Jun 3, 2022
View reviewed changes
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this technically a breaking change for some schemas (although I am not sure they could be successfully migrated, see my issue - I think this could have been used with an existing schema)?

@pimeys pimeys force-pushed the parser-database/prevent-mysql-set-default branch from dcb603a to 9a387c6 Compare June 3, 2022 10:46
@pimeys pimeys force-pushed the parser-database/prevent-mysql-set-default branch from 9a387c6 to 86e1b82 Compare June 3, 2022 10:46
@pimeys pimeys changed the title Indicate about proper escaping in the url Prevent MySQL SET DEFAULT Jun 3, 2022
@pimeys
Copy link
Contributor Author

pimeys commented Jun 3, 2022

Seems that these work on MySQL 8.x...

janpio
janpio requested changes Jun 3, 2022
View reviewed changes
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️

@pimeys
Copy link
Contributor Author

pimeys commented Jun 7, 2022

closing because my 8 should work.

@pimeys pimeys closed this Jun 7, 2022
@Jolg42 Jolg42 mentioned this pull request Oct 5, 2022
Closed
@janpio janpio deleted the parser-database/prevent-mysql-set-default branch November 15, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

MySQL does not support onDelete: setDefault
2 participants
@pimeys @janpio