Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle enum renames with default values #2972

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Handle enum renames with default values #2972

merged 1 commit into from
Jun 10, 2022

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented Jun 9, 2022

@pimeys pimeys requested a review from a team as a code owner June 9, 2022 16:30
@pimeys pimeys added this to the 4.0.x milestone Jun 9, 2022
tomhoule
tomhoule approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another point on why we should tackle reintrospection at some point — the PR is neat, lgtm!

@pimeys pimeys merged commit c80d746 into main Jun 10, 2022
@pimeys pimeys deleted the re-introspection/enum-defaults branch June 10, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule tomhoule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Invalid db pull / db push flow
2 participants
@pimeys @tomhoule