Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if re-introspecting renamed enum variants #2977

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Warn if re-introspecting renamed enum variants #2977

merged 1 commit into from
Jun 14, 2022

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented Jun 13, 2022

@pimeys pimeys requested a review from a team as a code owner June 13, 2022 14:29
@pimeys pimeys force-pushed the introspection/warning-if-reintrospecting-enum-defaults branch from d91749c to 8b1d53b Compare June 13, 2022 14:42
@pimeys pimeys added this to the 4.0.x milestone Jun 13, 2022
@pimeys pimeys force-pushed the introspection/warning-if-reintrospecting-enum-defaults branch from 8b1d53b to 3b3ece6 Compare June 13, 2022 14:53
tomhoule
tomhoule approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll try to take time to give myself a refresher on introspection warnings because I don't understand why we warn, things are working as they should — but it appears to be consistent with the rest, so 👍

@pimeys pimeys merged commit ae457f5 into main Jun 14, 2022
@pimeys pimeys deleted the introspection/warning-if-reintrospecting-enum-defaults branch June 14, 2022 07:45
@janpio
Copy link
Member

janpio commented Jun 14, 2022

We "warn" to inform the user that there is more in his schema than what Introspection got form the database. "warning" is actually not the best name for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule tomhoule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Invalid db pull / db push flow
3 participants
@pimeys @janpio @tomhoule