feat(me): implement timing events for spans #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
force-pushed
the
migration-engine/minimal-timings
branch
from
d70105f
to
cd1ed5c
Compare
This is a minimal tracing layer that times how long each span takes and logs an event with the result after the span is closed, for our own needs in performance observability. closes prisma/prisma#13693
tomhoule
force-pushed
the
migration-engine/minimal-timings
branch
from
cd1ed5c
to
2f40772
Compare
tomhoule
commented
Jun 21, 2022
| } | ||
| } | ||
| )) | ||
| .await? |
There was a problem hiding this comment.
indentation change, pretty much. span.enter() does not interact well with async and the replacement requires one level of identation more
tomhoule
commented
Jun 21, 2022
| #[derive(Default)] | ||
| pub struct TimingsLayer; | ||
|
|
||
| struct TimerTime(pub time::Instant, String); |
There was a problem hiding this comment.
the pub can/should go
pimeys
approved these changes
Jun 21, 2022
Yes it's a bit ridiculous when network is involved, but it's not always the case, and we display a human-readable version of the duration next to it, so I still think it's the right choice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal tracing layer that times how long each span takes and
logs an event with the result after the span is closed, for our own
needs in performance observability.
closes prisma/prisma#13693