datamodel: implement PSL string literal grammar proposal #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
force-pushed
the
psl-string-grammar
branch
from
254281a
to
43f5d2e
Compare
tomhoule
force-pushed
the
psl-string-grammar
branch
from
43f5d2e
to
31ced5f
Compare
Simplify pest grammar of string literals We want to tokenize invalid escape sequences and report them as such later in validation. This results in better error messages across the board. closes prisma/prisma#4167
...by the combination of the new postgres default parsing code from the scalar list defaults work and the new string literal code in PSL. closes prisma/prisma#12095
tomhoule
force-pushed
the
psl-string-grammar
branch
from
31ced5f
to
be1f1b8
Compare
tomhoule
commented
Jun 22, 2022
| @@ -1,20 +1,26 @@ | |||
| use diagnostics::Diagnostics; | |||
|
|
|||
tomhoule
commented
Jun 22, 2022
| // References: | ||
| // - https://www.ietf.org/rfc/rfc4627.txt | ||
| // - https://www.json.org/json-en.html | ||
| UNICODE_CONTROL_CHARACTER = _{ '\u{0000}'..'\u{001F}' } |
There was a problem hiding this comment.
should be called ASCII_CONTROL_CHARACTER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify pest grammar of string literals
We want to tokenize invalid escape sequences and report them as such
later in validation.
This results in better error messages across the board.
closes prisma/prisma#4167
and confirm that user issue is closed by the combination of the new postgres default parsing code from the
scalar list defaults work and the new string literal code in PSL.
closes prisma/prisma#12095