Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datamodel): move all relation reformatting logic to reformat.rs #3014

Conversation

tomhoule
Copy link
Contributor

@tomhoule tomhoule commented Jun 28, 2022

This makes it explicitly a private concern of the reformatter that the
rest of the code does not need to worry about. As a side effect, we do
not allocate anymore for potentially inferred fields in validations, and
some validations as well as lifting gets simpler.

closes prisma/prisma#13742 as a side effect

@tomhoule tomhoule requested a review from a team as a code owner June 28, 2022 13:42
This makes it explicitly a private concern of the reformatter that the
rest of the code does not need to worry about. As a side effect, we do
not allocate anymore for potentially inferred fields in validations, and
some validations as well as lifting gets simpler.

closes prisma/prisma#13742 as a side effect
@tomhoule tomhoule force-pushed the datamodel/move-all-magic-relation-reformatting-logic-to-reformat-rs branch from d8e0f09 to 1d7fa24 Compare June 28, 2022 13:48
@tomhoule tomhoule added this to the 4.1.0 milestone Jun 28, 2022
Copy link
Contributor

@pimeys pimeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes. niiiice.

@tomhoule tomhoule merged commit 46cd7ed into main Jun 28, 2022
@tomhoule tomhoule deleted the datamodel/move-all-magic-relation-reformatting-logic-to-reformat-rs branch June 28, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reformatter crash in relation code
2 participants