refactor(reformat): completely separate relation additions from AST reformatting #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eformatting That way we can do pure AST reformatting if we want, and reuse the logic for relation and relation scalar field additions in code actions. As a side-effect, that makes the formatter idempotent. There will be a follow-up PR to split the two functionalities in two different modules, but I stopped here for readability in this PR. closes prisma/prisma#12726
tomhoule
force-pushed
the
datamodel/move-all-magic-relation-reformatting-logic-to-reformat-rs
branch
from
edf1508
to
64b00fa
Compare
pimeys
approved these changes
Jun 29, 2022
tomhoule
deleted the
datamodel/move-all-magic-relation-reformatting-logic-to-reformat-rs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way we can do pure AST reformatting if we want, and reuse the logic
for relation and relation scalar field additions in code actions. As a
side-effect, that makes the formatter idempotent (and much simpler).
There will be a follow-up PR to split the two functionalities in two
different modules, but I stopped here for readability in this PR.
closes prisma/prisma#12726