fix(me): make @db.Float migrations idempotent on MSSQL #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the actual test name for database names. This was probably a bug that would have shown up with a few more tests, because we were going to reuse the same database name. - Nest existing tests under per-connector folders. - Port a few cockroach tests to see how things work and feel. The new tests feel great.
We weren't properly handling the implicit precision: we sent FLOAT, got back FLOAT(53), and interpreted that as different types, but they're the same. closes prisma/prisma#14052
pimeys
approved these changes
Jul 14, 2022
|
Doing the renaming on the branch for my next PR now, so we can merge this right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't properly handling the implicit precision: we sent FLOAT, got
back FLOAT(53), and interpreted that as different types, but they're the
same.
closes prisma/prisma#14052
The first commit is a follow-up to yesterday's introspection tests improvements.
that would have shown up with a few more tests, because we were going
to reuse the same database name.
tests feel great.