fix: validate integers to prevent overflow #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weakky
force-pushed
the
fix/integer-overflow
branch
from
5b57cab
to
4b79345
Compare
tomhoule
approved these changes
Sep 26, 2022
| impl std::fmt::Display for IntType { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| match self { | ||
| IntType::Signed8 => write!(f, "8-bit signed integer"), |
There was a problem hiding this comment.
nitpick (no need to fix now), but f.write_str("8-bit signed integer") does the same and is easier on the compiler
| (QueryValue::Int(i), ScalarType::Float) => Ok(PrismaValue::Float(BigDecimal::from(i))), | ||
| (QueryValue::Int(i), ScalarType::Decimal) => Ok(PrismaValue::Float(BigDecimal::from(i))), | ||
| (QueryValue::Int(i), ScalarType::BigInt) => Ok(PrismaValue::BigInt(i)), | ||
|
|
||
| (QueryValue::Float(f), ScalarType::Float) => Ok(PrismaValue::Float(f)), | ||
| (QueryValue::Float(f), ScalarType::Decimal) => Ok(PrismaValue::Float(f)), | ||
| (QueryValue::Float(f), ScalarType::Int) => match f.to_i64() { | ||
| (QueryValue::Float(f), ScalarType::Int(_)) => match f.to_i64() { | ||
| Some(converted) => Ok(PrismaValue::Int(converted)), |
There was a problem hiding this comment.
I don't know if there's a good place to persist that, but it would be good to document that we validate all integers except 64 bit integers because they are strings at the graphql level (IIUC).
Weakky
force-pushed
the
fix/integer-overflow
branch
from
e3ee62c
to
ff55d4b
Compare
Weakky
added a commit
that referenced
this pull request
Sep 27, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
internal doc
fixes prisma/prisma#13913