psl: fix database name clash validation with multiSchema #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation we have validates that no two models in the whole schema have the same database name. Database name is defined as the contents of the model's `@@map` attribute, or the model name if the model name does not have an `@@map` attribute. It is the name we give to the table/collection corresponding to the model in the database. When the `multiSchema` preview feature is turned on, the tables in the database can be in different schemas, so we have to adapt the validation to allow multiple models to have the same database name, as long as they are in a different schema. This is what this commit does. closes prisma/prisma#15009
tomhoule
force-pushed
the
psl/multi-schema-map-conflict
branch
from
9c6abca
to
18aec69
Compare
do4gr
approved these changes
Sep 30, 2022
pimeys
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation we have validates that no two models in the whole schema have the same database name. Database name is defined as the contents of the model's
@@mapattribute, or the model name if the model name does not have an@@mapattribute. It is the name we give to the table/collection corresponding to the model in the database.When the
multiSchemapreview feature is turned on, the tables in the database can be in different schemas, so we have to adapt the validation to allow multiple models to have the same database name, as long as they are in a different schema. This is what this commit does.closes prisma/prisma#15009