Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psl: take @@Schema into account in constraint & enum name clashes #3269

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

tomhoule
Copy link
Contributor

@tomhoule tomhoule commented Oct 6, 2022

@tomhoule tomhoule force-pushed the psl/multi-schema-extra-namespacing-validations branch from 0c062a8 to 9491fc1 Compare October 6, 2022 12:35
@tomhoule tomhoule changed the title [wip] multiSchema missing PSL validations psl: take @@Schema into account in constraint & enum name clashes Oct 6, 2022
pub fn new_duplicate_enum_database_name_error(span: Span) -> DatamodelError {
let msg = "An enum with the same database name is already defined.";
Self::new(msg, span)
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error could be nicer.

@tomhoule tomhoule marked this pull request as ready for review October 6, 2022 12:38
@tomhoule tomhoule requested a review from a team as a code owner October 6, 2022 12:38
@tomhoule tomhoule added this to the 4.5.0 milestone Oct 6, 2022
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests looks good 👍🏼

@tomhoule tomhoule merged commit 578406b into main Oct 11, 2022
@tomhoule tomhoule deleted the psl/multi-schema-extra-namespacing-validations branch October 11, 2022 12:00
@tomhoule
Copy link
Contributor Author

Reviewed on zoom with @do4gr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[multiSchema] check PSL validations for enum and composite type database name clashes
2 participants