Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(validation): disallow SetNull referential action on required referenced fields #3298

Merged
merged 13 commits into from
Oct 20, 2022
Merged

feat(validation): disallow SetNull referential action on required referenced fields #3298

merged 13 commits into from
Oct 20, 2022

Commits on Oct 17, 2022

  1. test: add skeleton for prohibiting SetNull ref actions referencing sc… 

    …alar fields
    @jkomyno
    jkomyno committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    9f35ca6 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. chore: merge main, fix conflicts

    @jkomyno
    jkomyno committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    8cf496e View commit details
    Browse the repository at this point in the history

  2. fix: add validation error when referencing a required field in a rela… 

    …tion with at least a SetNull referential action
    @jkomyno
    jkomyno committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    df9c3ca View commit details
    Browse the repository at this point in the history

  3. chore: revert datamodel_converter_tests.rs to how it was before

    @jkomyno
    jkomyno committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    115c1bb View commit details
    Browse the repository at this point in the history

  4. chore: minor update to validation message

    @jkomyno
    jkomyno committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    cfe0bba View commit details
    Browse the repository at this point in the history

  5. chore: fix pre-existing tests using SetNull

    @jkomyno
    jkomyno committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    68789bc View commit details
    Browse the repository at this point in the history

  6. chore: fix pre-existing tests using SetNull

    @jkomyno
    jkomyno committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    a722560 View commit details
    Browse the repository at this point in the history

  7. chore: fix pre-existing tests using SetNull

    @jkomyno
    jkomyno committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    bcbaa01 View commit details
    Browse the repository at this point in the history

  8. chore: removed leftover

    @jkomyno
    jkomyno committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    47e5b76 View commit details
    Browse the repository at this point in the history

  9. test: found possible regression

    @jkomyno
    jkomyno committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    a9a8d99 View commit details
    Browse the repository at this point in the history

  10. test(qe): removed deprecated SetNull tests whose schema is no longer … 

    …valid
    @jkomyno
    jkomyno committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    5a48246 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. test(vitess): used Restrict in place of SetNull to avoid surprising b… 

    …ehavior in 'referential_actions_are_kept_intact' test
    @jkomyno
    jkomyno committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    e0f2790 View commit details
    Browse the repository at this point in the history

  2. chore: address review nit

    @jkomyno
    jkomyno committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    2f30b37 View commit details
    Browse the repository at this point in the history