Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render enums using the datamodel renderer #3305

Merged
merged 6 commits into from Oct 20, 2022
Merged

Render enums using the datamodel renderer #3305

merged 6 commits into from Oct 20, 2022

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented Oct 19, 2022

@pimeys pimeys added this to the 4.6.0 milestone Oct 19, 2022
@pimeys pimeys requested a review from a team as a code owner October 19, 2022 18:36
@pimeys pimeys force-pushed the introspection-engine/use-datamodel-renderer-for-enums branch from 76e7101 to 205214b Compare October 19, 2022 18:42
@pimeys pimeys force-pushed the introspection-engine/use-datamodel-renderer-for-enums branch from 205214b to 2c947d2 Compare October 20, 2022 14:58
eviefp
eviefp approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@eviefp eviefp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one minor suggestion in comments.

introspection-engine/connectors/sql-introspection-connector/src/introspection.rs Show resolved Hide resolved
@pimeys pimeys force-pushed the introspection-engine/use-datamodel-renderer-for-enums branch from d424260 to 0e91004 Compare October 20, 2022 16:54
@pimeys pimeys merged commit 873cfc1 into main Oct 20, 2022
@pimeys pimeys deleted the introspection-engine/use-datamodel-renderer-for-enums branch October 20, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eviefp eviefp eviefp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pimeys @eviefp