Render composite types with the new renderer #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
force-pushed
the
introspection-engine/use-datamodel-renderer-for-composite-types
branch
from
82db30b
to
035425d
Compare
pimeys
force-pushed
the
introspection-engine/use-datamodel-renderer-for-composite-types
branch
from
3ff55d7
to
9e7163b
Compare
pimeys
force-pushed
the
introspection-engine/use-datamodel-renderer-for-composite-types
branch
from
9e7163b
to
bfe8426
Compare
pimeys
commented
Oct 24, 2022
| /// Here to cope with the initial issue of needing the DML | ||
| /// structures. Remove when we don't generate DML in intro | ||
| /// anymore. | ||
| pub fn from_dml(val: &'a dml::DefaultValue) -> Self { |
There was a problem hiding this comment.
Here might be some dragons. We'll see when models and fields are converted!
tomhoule
reviewed
Oct 25, 2022
There was a problem hiding this comment.
nice! I'm still not visualizing the full picture with this data structure when we cut out dml from introspection and stop re-rendering everything, but rather express the introspection result as inserts/removals on the original schema (that's probably what it will take if we want to preserve comments). Let's keep pushing forward and see how things pan out
introspection-engine/datamodel-renderer/src/datamodel/field_type.rs
Outdated
Show resolved
Hide resolved
tomhoule
approved these changes
Oct 25, 2022
pimeys
deleted the
introspection-engine/use-datamodel-renderer-for-composite-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: prisma/prisma#15800