New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qe: fix mongo logging for updateMany #3321
Conversation
Looking into why buildkite reports a failure. The test keeps passing locally with mongo 4.4, and 4.2. Apparently, logs are not being received in the test. I will keep digging.
And the code in that offending line: https://github.com/prisma/prisma-engines/pull/3321/files#diff-09e5f77622188cb35ae340b9facc20b10a4cd9e707a7aa9a1d13d3d5fdde7fdeR49 |
35b2f84
to
ce1f52d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Good fix and a nice test to go with it.
@@ -53,7 +53,7 @@ fn create_env_filter(log_queries: bool, qe_log_level: &str) -> EnvFilter { | |||
.add_directive(format!("query_core={}", &qe_log_level).parse().unwrap()) | |||
.add_directive(format!("query_connector={}", &qe_log_level).parse().unwrap()) | |||
.add_directive(format!("sql_query_connector={}", &qe_log_level).parse().unwrap()) | |||
.add_directive(format!("mongodb_query_connector={}", &qe_log_level).parse().unwrap()); | |||
.add_directive("mongodb_query_connector=debug".parse().unwrap()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
Fixes prisma/prisma#15467
The patch includes a regression test reproducing the exact user concern and a following comment fixing the code.
cc @prisma/client-team-rust