Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrating after altering an Enum type and chaing the default value of an Enum[] column no longer crashes on Postgres #3379

Merged
merged 4 commits into from Nov 10, 2022
Merged

fix: migrating after altering an Enum type and chaing the default value of an Enum[] column no longer crashes on Postgres #3379

merged 4 commits into from Nov 10, 2022

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Nov 9, 2022 •
edited

This PR deprecates #3347.

Closes prisma/prisma#15705.

@jkomyno jkomyno mentioned this pull request Nov 9, 2022
Closed
@jkomyno jkomyno changed the title chore: set up skeleton to fix issue #15705 fix: migrate enum list defaults without crashes on Postgres Nov 9, 2022
@jkomyno jkomyno added this to the 4.7.0 milestone Nov 9, 2022
@jkomyno jkomyno marked this pull request as ready for review November 9, 2022 17:19
@jkomyno jkomyno requested a review from a team as a code owner November 9, 2022 17:19
tomhoule
tomhoule approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could expose the bug and in which conditions it happens in the commit message, for future reference.

@jkomyno jkomyno changed the title fix: migrate enum list defaults without crashes on Postgres fix: migrating after altering an Enum type and chaing the default value of an Enum[] column no longer crashes on Postgres Nov 10, 2022
@jkomyno jkomyno merged commit a93b663 into main Nov 10, 2022
@jkomyno jkomyno deleted the fix/enum-list-default-migration branch November 10, 2022 17:17
This was referenced Aug 10, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule tomhoule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7.0
2 participants
@jkomyno @tomhoule