New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make referentialIntegrity preview feature GA #3428
Conversation
Changed code - deprecated the preview feature - removed error if preview feature is missing but the datasource property is set - removed unneeded tests - updated test-api Next commit: remove all mentions of the preview feature flag
Waiting for prisma/prisma-engines#3428 to be merged first. Related #16224
Done with Tom, Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny change about a line we forgot to delete, and then we're good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
@@ -68,7 +68,7 @@ async fn a_table_without_uniques_should_ignore(api: &TestApi) -> TestResult { | |||
Ok(()) | |||
} | |||
|
|||
#[test_connector(tags(Mysql))] | |||
#[test_connector(tags(Mysql), exclude(Vitess))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need to exclude Vitess now?
@@ -1,6 +1,6 @@ | |||
use introspection_engine_tests::test_api::*; | |||
|
|||
#[test_connector(tags(Mysql))] | |||
#[test_connector(tags(Mysql), exclude(Vitess))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need to exclude Vitess now?
@@ -3,7 +3,7 @@ use indoc::indoc; | |||
use introspection_engine_tests::test_api::*; | |||
use test_macros::test_connector; | |||
|
|||
#[test_connector(tags(Mysql))] | |||
#[test_connector(tags(Mysql), exclude(Vitess))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need to exclude Vitess now?
@@ -708,7 +708,7 @@ async fn expression_indexes_should_be_ignored_on_sqlite(api: &TestApi) -> TestRe | |||
Ok(()) | |||
} | |||
|
|||
#[test_connector(tags(Mysql))] | |||
#[test_connector(tags(Mysql), exclude(Vitess))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need to exclude Vitess now?
Related prisma/prisma#16224
Changes