Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(psl): support warnings in tests #3432

Merged
merged 7 commits into from
Nov 22, 2022
Merged

feat(psl): support warnings in tests #3432

merged 7 commits into from
Nov 22, 2022

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Nov 22, 2022 •
edited

This PR adds support for psl warning diagnostics to the validation_tests test suite (which previously only supported error diagnostics)

Context: #3429 introduced a new kind of validation warning that we wanted to test. As validation_tests is the place where the Schema team should write new validation unit tests, this PR fixes such a shortcoming.

tomhoule
tomhoule reviewed Nov 22, 2022
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Only small things to fix, but on the whole, as discussed on zoom, super nice contribution.

psl/diagnostics/src/pretty_print.rs Outdated Show resolved Hide resolved
psl/diagnostics/src/error.rs Outdated Show resolved Hide resolved
psl/psl/tests/validation_tests.rs Outdated Show resolved Hide resolved
psl/psl/tests/validation_tests.rs Outdated Show resolved Hide resolved
@jkomyno jkomyno marked this pull request as ready for review November 22, 2022 15:45
@jkomyno jkomyno requested a review from a team as a code owner November 22, 2022 15:45
@jkomyno jkomyno mentioned this pull request Nov 22, 2022
Merged
3 tasks
tomhoule
tomhoule approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

psl/diagnostics/src/error.rs Outdated Show resolved Hide resolved
@Jolg42 Jolg42 added this to the 4.7.0 milestone Nov 22, 2022
@jkomyno jkomyno merged commit a03afcd into main Nov 22, 2022
@jkomyno jkomyno deleted the feat/psl-support-warnings-in-tests branch November 22, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule tomhoule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkomyno @tomhoule @Jolg42