feat(psl): polish validation warnings before relationMode GA
#3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janpio
reviewed
Nov 25, 2022
psl/builtin-connectors/src/mysql_datamodel_connector/validations.rs
Outdated
Show resolved
Hide resolved
Jolg42
approved these changes
Nov 25, 2022
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes prisma/prisma#16440.
SetDefaultonmysql"""
MySQLdoes not actually support theSetDefaultreferential action, so using it may result in unexpected errors. Read more at https://pris.ly/d/mysql-set-default"""
SetNullonpostgres"""
The
onDeletereferential action of a relation should not be set toSetNullwhen a referenced field is required. We recommend either to choose another referential action, or to make the referenced fields optional. Read more at https://pris.ly/d/postgres-set-null"""
Missing indexes on
relationMode = "prisma""""
With
relationMode = "prisma", no foreign keys are used, so relation fields will not benefit from the index usually created by the relational database under the hood. This can lead to poor performance when querying these fields. We recommend adding an index manually. Learn more at https://pris.ly/d/relation-mode-prisma-indexes"""