psl: fix newline boundary search in relation reformatting #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
commented
Nov 30, 2022
|
|
||
| model somemodel { | ||
| frownyFaceId String | ||
| frownyFace frownyface // 囧 @relation(fields: [], references: []) |
There was a problem hiding this comment.
this is very wrong
jkomyno
approved these changes
Nov 30, 2022
|
This is still broken, we have to address #3457 (comment) |
tomhoule
force-pushed
the
psl-reformatter-char-boundaries
branch
from
cb87bb6
to
734e168
Compare
When adding an @relation attribute to a forward relation field in the relation reformatting code that deals with adding missing relation fields and attributes, we searched for the last character before a newline to check whether it is a carriage return, but we failed to check whether the byte offset was a char boundary first. This caused crashes. closes prisma/prisma#14895
tomhoule
force-pushed
the
psl-reformatter-char-boundaries
branch
from
734e168
to
a3e1d2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding an @relation attribute to a forward relation field in the relation reformatting code that deals with adding missing relation fields and attributes, we searched for the last character before a newline to check whether it is a carriage return, but we failed to check whether the byte offset was a char boundary first. This caused crashes.
closes prisma/prisma#14895