fix: don't compact findUniqueOrThrow

[Weakky]

Overview

fixes prisma/prisma#16548

[miguelff]

Tried the following reproduction, from issue 16549, against this branch's binary engine:

Schema

generator client {
  provider        = "prisma-client-js"
  output          = "../node_modules/.prisma/client"
  engineType      = "binary"
  previewFeatures = []
}

datasource db {
  provider = "postgresql"
  url      = "postgresql://prisma:prisma@localhost:5432"
}

model Post {
  id        String   @id
  createdAt DateTime @default(now())
  updatedAt DateTime @updatedAt

  title String

  @@map("posts")
}

index.ts

import { PrismaClient } from '.prisma/client';

const prisma = new PrismaClient({
  log: ["info", "error", "query", "warn"],
  __internal: {
    engine: {
      endpoint: "http://127.0.0.1:57581",
    },
  },
} as any);

const id1 = 'VALID_ID1';
const id2 = 'VALID_ID2';

async function setup(): Promise<void> {
  // 1. Clear DB
  console.log('DeleteMany:', await prisma.post.deleteMany());

  // 2. Add posts
  console.log('\nCreate posts:', await prisma.post.createMany({
    data: [
      {
        id: id1,
        title: 'New post',
      },
      {
        id: id2,
        title: 'New post 2!',
      }
    ],
  }));
}

async function find(id: string): Promise<void> {
  // 1. Query it with findUnique (no error)
  console.log('\nFindUnique:', await prisma.post.findUnique({
    where: { id },
  }));

  // 2. Query it with findUniqueOrThrow (crash??)
  console.log('\nFindUniqueOrThrow:', await prisma.post.findUniqueOrThrow({
    where: { id },
  }));
}

async function main(): Promise<void> {
  await setup();
  await Promise.all([id1, id2].map(find));
}

main().then(() => console.log('OK!')).catch((err) => console.error(err));

Output: OK!

However, if I issue another request to findUniqueOrThow with an invalid ID:

...
await Promise.all([id1, id2, "INVALID_ID3"].map(find));

I get:

  prisma:engine  {
  error: TypeError: Cannot read properties of undefined (reading '0')
      at /Users/miguel/GitHub/prisma/prisma/reproductions/16549/node_modules/.prisma/client/runtime/index.js:29021:53
      at Array.map (<anonymous>)
      at /Users/miguel/GitHub/prisma/prisma/reproductions/16549/node_modules/.prisma/client/runtime/index.js:29019:28
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
} +68ms
  prisma:client:request_handler  TypeError: Cannot read properties of undefined (reading '0')
    at /Users/miguel/GitHub/prisma/prisma/reproductions/16549/node_modules/.prisma/client/runtime/index.js:29021:53
    at Array.map (<anonymous>)
    at /Users/miguel/GitHub/prisma/prisma/reproductions/16549/node_modules/.prisma/client/runtime/index.js:29019:28
    at processTicksAndRejections (node:internal/process/task_queues:95:5) +0ms
prisma:error Cannot read properties of undefined (reading '0')
  prisma:client:request_handler  TypeError: Cannot read properties of undefined (reading '0')
    at /Users/miguel/GitHub/prisma/prisma/reproductions/16549/node_modules/.prisma/client/runtime/index.js:29021:53
    at Array.map (<anonymous>)
    at /Users/miguel/GitHub/prisma/prisma/reproductions/16549/node_modules/.prisma/client/runtime/index.js:29019:28
    at processTicksAndRejections (node:internal/process/task_queues:95:5) {
  clientVersion: '0.0.0'
} +3ms
prisma:error Cannot read properties of undefined (reading '0')
  prisma:client:request_handler  TypeError: Cannot read properties of undefined (reading '0')
    at /Users/miguel/GitHub/prisma/prisma/reproductions/16549/node_modules/.prisma/client/runtime/index.js:29021:53
    at Array.map (<anonymous>)
    at /Users/miguel/GitHub/prisma/prisma/reproductions/16549/node_modules/.prisma/client/runtime/index.js:29019:28
    at processTicksAndRejections (node:internal/process/task_queues:95:5) {
  clientVersion: '0.0.0'
} +0ms
prisma:error Cannot read properties of undefined (reading '0')
TypeError: Cannot read properties of undefined (reading '0')
    at /Users/miguel/GitHub/prisma/prisma/reproductions/16549/node_modules/.prisma/client/runtime/index.js:29021:53
    at Array.map (<anonymous>)
    at /Users/miguel/GitHub/prisma/prisma/reproductions/16549/node_modules/.prisma/client/runtime/index.js:29019:28
    at processTicksAndRejections (node:internal/process/task_queues:95:5) {
  clientVersion: '0.0.0'
}

I think this might be a different problem. Will need to investigate tomorrow.

[miguelff]

This can be merged as-is. The problem subject of my previous comment

...
await Promise.all([id1, id2, "INVALID_ID3"].map(find));

Is a different one and will be addressed by prisma/prisma#16574

[nowlena]

I am seeing the following issue with batching:

• prisma.user.findUnique({ where { id } }); -> batching occurs
• prisma.user.findUnique({ where { id } }).posts(); -> batching occurs
• prisma.user.findUniqueOrThrow({ where { id } }); -> batching does NOT occur
• prisma.user.findUniqueOrThrow({ where { id } }).posts(); -> batching does NOT occur

example based on Query optimization page