me: implement multi-schema reset on postgres #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the migration engine `reset` command resets the schema in the search path, on postgresql and cockroachdb. This is not the expected behaviour when working with multiple schemas defined in the `schemas` datasource property: users expect all schemas to be reset, moreover migrate dev will be broken if we do not do that, because it expects reset to do its job before re-applying migrations. In this commit, we take into account the namespaces defined in the Prisma schema the migration engine is initialized with. We reset these schemas, when defined, *in addition to* the schema in the search path. The reason we still the search path into account is because that is where we create and expect the _prisma_migrations table to live. I expect we may want to revisit that design choice (issue: prisma/prisma#16565). closes prisma/prisma#16561
tomhoule
commented
Dec 1, 2022
| @@ -71,6 +71,7 @@ impl SchemaAssertion { | |||
| } | |||
| } | |||
|
|
|||
| #[track_caller] | |||
There was a problem hiding this comment.
This puts the error on the right line in the test, instead of inside the assertion function.
eviefp
reviewed
Dec 1, 2022
migration-engine/connectors/sql-migration-connector/src/flavour/postgres.rs
Outdated
Show resolved
Hide resolved
In multi-schema mode, instead of wiping out the schema from the search path in addition to the schemas defined in the datasource, we now only drop the migrations table in the main schema. This should match migrate dev's expectations around resets.
pimeys
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the migration engine
resetcommand resets the schema in the search path, on postgresql and cockroachdb.This is not the expected behaviour when working with multiple schemas defined in the
schemasdatasource property: users expect all schemas to be reset, moreover migrate dev will be broken if we do not do that, because it expects reset to do its job before re-applying migrations.In this commit, we take into account the namespaces defined in the Prisma schema the migration engine is initialized with. We reset these schemas, when defined, in addition to the schema in the search path. The reason we still the search path into account is because that is where we create and expect the _prisma_migrations table to live. I expect we may want to revisit that design choice
(issue: prisma/prisma#16565).
closes prisma/prisma#16561