describer: multiSchema-aware SQL Server #3465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
force-pushed
the
describer/sql-server-multi-schema
branch
from
f90407c
to
793b1ef
Compare
eviefp
approved these changes
Dec 6, 2022
Comment on lines
+406
to
+421
| //cross schema | ||
| // fks | ||
| // enums | ||
|
|
||
| //Edge cases | ||
| //name conflicts | ||
| // what if the names are used somewhere??? | ||
| // table | ||
| // enum | ||
| //invalid names | ||
| // schema | ||
| // table | ||
| // enum | ||
| // re-introspection | ||
| // table | ||
| // enum |
There was a problem hiding this comment.
Should this be here? If yes, could you elaborate such that it makes sense for everyone?
Or maybe it needs to be a GH issue or something?
There was a problem hiding this comment.
It was just copied from the other file. I do not know should it be here, but also didn't want to delete it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds namespaces to SQL Server describer to be used in further work in migrations and introspection.
Due to SQL Server not allowing us to pass a vector as a statement parameter such as PostgreSQL does, we considered a few options:
Part of: prisma/prisma#16627 and prisma/prisma#15584