intro: Handle relation field introspection using the pair setup #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
force-pushed
the
intro/relation-pairs
branch
3 times, most recently
from
ad223a0
to
e3a9c69
Compare
pimeys
force-pushed
the
intro/relation-pairs
branch
2 times, most recently
from
d7a00d7
to
746bd5a
Compare
pimeys
commented
Dec 8, 2022
| @@ -1,7 +1,9 @@ | |||
| use super::scalar_field; | |||
There was a problem hiding this comment.
Sorry for the messy diff. Moved the single model rendering to a separate function.
pimeys
force-pushed
the
intro/relation-pairs
branch
from
746bd5a
to
a8f5524
Compare
pimeys
changed the title
pimeys
force-pushed
the
intro/relation-pairs
branch
from
a8f5524
to
e39e066
Compare
pimeys
force-pushed
the
intro/relation-pairs
branch
from
e39e066
to
94110fc
Compare
tomhoule
approved these changes
Dec 8, 2022
| @@ -279,9 +411,11 @@ pub fn calculate_datamodel( | |||
| introspection_map: &introspection_map, | |||
| }; | |||
|
|
|||
| let introspection_map = crate::introspection_map::IntrospectionMap::new(input); | |||
| input.introspection_map = &introspection_map; | |||
There was a problem hiding this comment.
I don't understand why we are creating the introspection map twice in this function. Maybe we should make IntrospectionMap::new()` into something that mutates the input instead?
There was a problem hiding this comment.
The input takes a reference... That's a bit of an issue. Let's see that later.
| } | ||
|
|
||
| let rendered = if input.render_config { | ||
| let psl_string = if input.render_config { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: prisma/prisma#16547