Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

me: Clean all namespaces for the shadow database #3531

Merged
merged 1 commit into from
Dec 19, 2022
Merged

me: Clean all namespaces for the shadow database #3531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions migration-engine/core/src/commands/diagnose_migration_history.rs
View file
Open in desktop
Expand Up @@ -136,7 +136,7 @@ pub async fn diagnose_migration_history(
.database_schema_from_diff_target(DiffTarget::Migrations(&applied_migrations), None, namespaces.clone())
.await;
let to = connector
.database_schema_from_diff_target(DiffTarget::Database, None, namespaces)
.database_schema_from_diff_target(DiffTarget::Database, None, namespaces.clone())
.await;
let drift = match from.and_then(|from| to.map(|to| connector.diff(from, to))).map(|mig| {
if connector.migration_is_empty(&mig) {
Expand All @@ -157,7 +157,7 @@ pub async fn diagnose_migration_history(
// TODO(MultiSchema): Not entirely sure passing no namespaces here is correct. Probably should
// also grab this as a CLI argument.
connector
.validate_migrations(&migrations_from_filesystem, None)
.validate_migrations(&migrations_from_filesystem, namespaces)
.await
.err()
} else {
Expand Down