fix(mongo): disallow filtered nested disconnect based on inlining #4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelff
approved these changes
May 31, 2023
| enumflags2::make_bitflags!(ConnectorCapability::{#(#required_capabilities|)*}), | ||
| enumflags2::make_bitflags!(ConnectorCapability::{#(#required_capabilities)|*}), |
There was a problem hiding this comment.
How was this even compiling before?
Comment on lines
183
to
174
| if ctx.has_capability(ConnectorCapability::FilteredInlineChildNestedToOneDisconnect) | ||
| // If the disconnect happens on the inline side, then we can allow filters | ||
| || parent_field.related_field().is_inlined_on_enclosing_model() | ||
| { | ||
| types.push(InputType::object(filter_objects::where_object_type( | ||
| ctx, | ||
| &parent_field.related_model(), | ||
| ))); | ||
| } |
There was a problem hiding this comment.
Do we have any other test that actually performs the disconnect when there is no need to join on a foreign collection?
There was a problem hiding this comment.
Yes. The relation link tests that I have modified are inlining the relation on both sides (they generate a bunch of different datamodels)
Weakky
force-pushed
the
fix/extended-where-disconnect
branch
from
f8a5c40
to
778dee5
Compare
CodSpeed Performance ReportMerging #4008 Summary
|
miguelff
added a commit
that referenced
this pull request
Jun 2, 2023
* origin/main: qe: fix regression on CreateOne data argument nullability (#4011) fix(mongo): disallow filtered nested disconnect based on inlining (#4008) nix: make quaint/shell.nix work on darwin (#4013) qe: cache resolved QuerySchema input & output object fields (#4009) Optimized dual uploads from engineer (#3981) qe: remove XML scalar type (#3957) qe: make schema building lazy (#3977) introspection: fix reintrospection of @default(uuid()) @db.Uuid (#4004) build(deps): bump h2 from 0.3.15 to 0.3.17 (#3872)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fixes prisma/prisma#16869 (BREAKING)
Please read the issue above to understand the root problem.
Note: We could perform a separate read and then perform the update based on the found ids. Not sure it's worth adding complexity to the graph before we have demand.