Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: GA extendedWhereUnique #4061

Merged
merged 4 commits into from
Jul 5, 2023
Merged

feat: GA extendedWhereUnique #4061

merged 4 commits into from
Jul 5, 2023

Conversation

Weakky
Copy link
Member

@Weakky Weakky commented Jul 5, 2023 •
edited

Overview

Contributes to prisma/prisma#19380

Deprecates the extendedWhereUnique preview feature flag to make it GA for Prisma 5

@Weakky Weakky requested a review from a team as a code owner July 5, 2023 13:42
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 5, 2023 •
edited

CodSpeed Performance Report

Merging #4061 will degrade performances by 35.43%

Comparing feat/ga-extended-where-unique (e93d07c) with main (a632441)

Summary

❌ 1 regressions
✅ 10 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/ga-extended-where-unique Change
❌ mutation 20.7 ms 32.1 ms -35.43%

@Weakky Weakky added this to the 5.0.0 milestone Jul 5, 2023
@Jolg42 Jolg42 requested review from miguelff and jkomyno July 5, 2023 16:10
@Jolg42 Jolg42 merged commit eac90b2 into main Jul 5, 2023
46 of 48 checks passed
@Jolg42 Jolg42 deleted the feat/ga-extended-where-unique branch July 5, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelff miguelff miguelff approved these changes

@Jolg42 Jolg42 Jolg42 left review comments

@jkomyno jkomyno Awaiting requested review from jkomyno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Weakky @miguelff @Jolg42