Core redesign v2 #46

dpetrick · 2019-09-19T12:25:07Z

Wip

Fundamentally changes query execution model.
Changes connector interface to symmetric read and write, as well as an exposed transactional model.
Moves a ton of responsibilities, and thus code, into the core.

POC flip creates.

Moved parser into query doc. Removed next wave of previous hacks.

Cleanup.

Nested updates require fairly major changes.

Cleanup.

Implement Get expression & evaluation.

Fix inconsistent code formatting.

…to core_redesign_v2

(Always swap top down)

Next: Cleanup.

Cleanup.

pimeys · 2019-10-29T16:52:32Z

query-engine/connectors/query-connector/src/error.rs

@@ -114,6 +114,10 @@ pub enum ConnectorError {

    #[fail(display = "Authentication failed for user '{}'", user)]
    AuthenticationFailed { user: String },
+
+    // Todo: Temporary!


pimeys · 2019-10-29T16:54:12Z

query-engine/connectors/query-connector/src/interface.rs

+
+    fn delete_records(&mut self, model: ModelRef, where_: Filter) -> crate::Result<usize>;
+
+    // We plan to remove the methods below in the future. We want emulate them with the ones above. Those should suffice.


Removing them before or after merge?

pimeys · 2019-10-29T16:58:16Z

query-engine/connectors/sql-query-connector/src/database/transaction.rs

+use connector_interface::*;
+use std::marker::PhantomData;
+
+pub struct SqlConnectorTransaction<'a, T> {


We probably can get rid of this when we asyncify the code.

pimeys · 2019-10-29T17:03:30Z

query-engine/connectors/sql-query-connector/src/query_builder/write/mod.rs

-mod builder;
-mod delete_actions;
-mod nested_actions;
+use crate::error::SqlError;


In the whole file, is there a different indentation than in the other files? Looks like 2 spaces instead of 4...

At least in some of the lines...

pimeys · 2019-10-29T17:05:39Z

query-engine/connectors/sql-query-connector/src/query_builder/write/mod.rs

+    Some(result)
+  }
+
+  // pub fn update_one(model: ModelRef, id: &GraphqlId, args: &PrismaArgs) -> crate::Result<Option<Update<'static>>> {


pimeys · 2019-10-29T17:09:18Z

query-engine/core/src/executor/interpreting_executor.rs

+        }
+    }
+
+    pub fn with_interpreter<'a, F>(&self, f: F) -> ConnectorResult<Response>


This might be nasty with async/await. Luckily we might not need this kind of arch soon... See https://github.com/prisma/prisma-engine/blob/bench/query-engine/connectors/sql-query-connector/src/transactional/mod.rs#L21

So instead of with_transaction {} we can just get a connection and start a transaction!

pimeys · 2019-10-29T17:12:55Z

query-engine/core/src/interpreter/error.rs

+    }
+}
+
+// impl From<InterpreterError> for ConnectorError {


pimeys · 2019-10-29T17:14:31Z

query-engine/core/src/interpreter/expressionista.rs

+            .collect()
+    }
+
+    // fn run_node_transformers(transformers: Vec<(String, ParentIdsFn)>) {


pimeys · 2019-10-29T17:20:06Z

query-engine/core/src/query_graph/formatters.rs

+use super::*;
+use std::fmt::{self, Display};


See if everything here can implement Display.

Using the Formatter is a better idea than allocating a new String every time.

pimeys · 2019-10-29T17:21:14Z

query-engine/core/src/query_graph/invariance_rules.rs

+}
+
+/// Only allow multiple parent edges if all parents are ancestors of each other.
+fn only_allow_related_parents_edges(_graph: &QueryGraph) -> QueryGraphResult<()> {


pimeys · 2019-10-29T17:22:37Z

query-engine/core/src/query_graph_builder/error.rs

+    }
+}
+
+// impl fmt::Display for QueryValidationError {


Update to tokio 0.2 and futures 0.3

dpetrick and others added 30 commits August 27, 2019 17:11

First experimentation with query graphs.

d254778

POC interpret embedded program.

20ab736

POC flip creates.

Intermediate commit.

087e310

Basic read experimentation

8aabd34

First functional POC.

143968f

Intermediate.

41c3f8c

Implement write serialization.

b722f58

Merge branch 'core_redesign_v2' into refactor

29adaaf

More refactors.

1bea23e

QueryGraph refactor

9058218

First swing at removing hacks, restructuring the core.

728676e

Intermediate commit. Non-compiling state.

a201704

Query document module.

3b94927

Moved parser into query doc. Removed next wave of previous hacks.

First e2e POC for new query building.

5979287

Experimentation with new query graph building for writes.

098e9a7

Cleanup.

Minimal write with read query implemented.

ee13d23

Experimentation with flattening nested writes.

403104b

Further experimentation with dependent queries.

f690cb5

Nested updates require fairly major changes.

Basic nested update POC.

ff4ac32

Cleanup.

Prototype different result serialization.

87a5f34

Implement Get expression & evaluation.

add new connector interface and implement it for Postgres

f09de7d

convert to mod.rs

2c5db55

move ConnectorTransaction to own file

772cec4

implement new connector interface for MySQL and SQLite

6c16122

Eliminate RefCells, use ext. mutability instead.

d35134f

remove file that should not be in git

ea27926

consolidate two ways to set a current connector

8e927fb

incorporate review feedback

e5c843b

implement create record

59d18a3

add update_records and delete_records to the new interface

2f7dee7

mavilein and others added 12 commits October 17, 2019 16:41

debugging helpers

4a33a96

improve Display for CreateRecord

b24d15a

fix test expectation

5280692

nested upsert: fix logic for requirement of where argument

514c773

Improve graph formatting.

7db49c4

Fix inconsistent code formatting.

Treat flow node parents differently while swapping

5f11f8a

Merge branch 'core_redesign_v2' of github.com:prisma/prisma-engine in…

c01cea4

…to core_redesign_v2

"Fix" swapping order issue.

ae190ff

(Always swap top down)

Fix more tests.

d162ca2

Fix transactions.

bbaaada

Intermediate cleanup.

721e619

Fix all tests.

e3d6e93

Next: Cleanup.

mavilein mentioned this pull request Oct 28, 2019

Error: QueryError(QueryError(UniqueConstraintViolation { field_name: "A, _MovieToWriter" } prisma/prisma#768

Closed

dpetrick added 3 commits October 28, 2019 15:10

Cleanup unused code.

aed6090

Cleanup debug output.

7db288d

WIP extract delete checks to graph.

cfb12dc

tomhoule force-pushed the master branch from 05fe036 to 74e438e Compare October 28, 2019 20:48

dpetrick added 4 commits October 29, 2019 14:16

More deletion checks.

a20b35a

Fix delete + nested delete.

74c7c1f

Cleanup.

Merge branch 'master' into core_redesign_v2

39c0e3c

Merge branch 'master' into core_redesign_v2

7c6e3d2

dpetrick changed the title ~~[WIP] Core redesign v2~~ Core redesign v2 Oct 29, 2019

dpetrick added 2 commits October 29, 2019 17:22

Ignore invariance test, will be reintroduced later.

a76848d

Default to info in test runs.

023c3a9

pimeys reviewed Oct 29, 2019

View reviewed changes

Fmt run.

4bd5c3d

pimeys suggested changes Oct 29, 2019

View reviewed changes

dpetrick merged commit ad52689 into master Oct 30, 2019

dpetrick deleted the core_redesign_v2 branch October 30, 2019 09:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Core redesign v2 #46

Core redesign v2 #46

dpetrick commented Sep 19, 2019

pimeys Oct 29, 2019

pimeys Oct 29, 2019

pimeys Oct 29, 2019

pimeys Oct 29, 2019

pimeys Oct 29, 2019

pimeys Oct 29, 2019

pimeys Oct 29, 2019

pimeys Oct 29, 2019

pimeys Oct 29, 2019

pimeys Oct 29, 2019

pimeys Oct 29, 2019

pimeys Oct 29, 2019

pimeys Oct 29, 2019


		fn delete_records(&mut self, model: ModelRef, where_: Filter) -> crate::Result<usize>;

		// We plan to remove the methods below in the future. We want emulate them with the ones above. Those should suffice.

Core redesign v2 #46

Core redesign v2 #46

Conversation

dpetrick commented Sep 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment