Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test all identifier types on mysql #593

Merged
merged 2 commits into from Mar 19, 2020
Merged

Test all identifier types on mysql #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd1fb1d
Test all PK types on mysql
tomhoule Mar 19, 2020
59ecaba
Test MySQL filter types
tomhoule Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
204 changes: 165 additions & 39 deletions query-engine/prisma/src/tests/type_mappings/mysql_types.rs
View file
Open in desktop
Expand Up @@ -53,6 +53,45 @@ const CREATE_TYPES_TABLE: &str = indoc! {
"##
};

const CREATE_ONE_TYPES_QUERY: &str = indoc! {
"
mutation {
createOnetypes(
data: {
numeric_integer_tinyint: 12,
numeric_integer_smallint: 350,
numeric_integer_int: 9002,
numeric_integer_bigint: 30000,
numeric_floating_decimal: 3.14
numeric_floating_float: -32.0
numeric_fixed_double: 0.14
numeric_fixed_real: 12.12
numeric_bit: 4
numeric_boolean: true
date_date: \"2020-02-27T00:00:00Z\"
date_datetime: \"2020-02-27T19:10:22Z\"
date_timestamp: \"2020-02-27T19:11:22Z\"
date_time: \"2020-02-20T12:50:01Z\"
date_year: 2012
string_char: \"make dolphins easy\"
string_varchar: \"dolphins of varying characters\"
string_text_tinytext: \"tiny dolphins\"
string_text_text: \"dolphins\"
string_text_mediumtext: \"medium dolphins\"
string_text_longtext: \"long dolphins\"
string_binary_binary: \"hello 2020\"
string_blob_tinyblob: \"smol blob\"
string_blob_mediumblob: \"average blob\"
string_blob_blob: \"very average blob\"
string_blob_longblob: \"loong looooong bloooooooob\"
string_enum: \"jellicle_cats\"
json: \"{\\\"name\\\": null}\"
}
) { id }
}
"
};

#[test_each_connector(tags("mysql"))]
async fn mysql_types_roundtrip(api: &TestApi) -> TestResult {
api.execute_sql(CREATE_TYPES_TABLE).await?;
Expand Down Expand Up @@ -102,44 +141,7 @@ async fn mysql_types_roundtrip(api: &TestApi) -> TestResult {

// Write the values.
{
let write = indoc! {
"
mutation {
createOnetypes(
data: {
numeric_integer_tinyint: 12,
numeric_integer_smallint: 350,
numeric_integer_int: 9002,
numeric_integer_bigint: 30000,
numeric_floating_decimal: 3.14
numeric_floating_float: -32.0
numeric_fixed_double: 0.14
numeric_fixed_real: 12.12
numeric_bit: 4
numeric_boolean: true
date_date: \"2020-02-27T00:00:00Z\"
date_datetime: \"2020-02-27T19:10:22Z\"
date_timestamp: \"2020-02-27T19:11:22Z\"
date_time: \"2020-02-20T12:50:01Z\"
date_year: 2012
string_char: \"make dolphins easy\"
string_varchar: \"dolphins of varying characters\"
string_text_tinytext: \"tiny dolphins\"
string_text_text: \"dolphins\"
string_text_mediumtext: \"medium dolphins\"
string_text_longtext: \"long dolphins\"
string_binary_binary: \"hello 2020\"
string_blob_tinyblob: \"smol blob\"
string_blob_mediumblob: \"average blob\"
string_blob_blob: \"very average blob\"
string_blob_longblob: \"loong looooong bloooooooob\"
string_enum: \"jellicle_cats\"
json: \"{\\\"name\\\": null}\"
}
) { id }
}
"
};
let write = CREATE_ONE_TYPES_QUERY;

let write_response = engine.request(write).await;

Expand Down Expand Up @@ -273,7 +275,7 @@ async fn mysql_bit_columns_are_properly_mapped_to_signed_integers(api: &TestApi)
Ok(())
}

#[test_each_connector(tags("mysql"), log = "debug")]
#[test_each_connector(tags("mysql"))]
async fn mysql_floats_do_not_lose_precision(api: &TestApi) -> TestResult {
api.execute_sql(CREATE_TYPES_TABLE).await?;

Expand Down Expand Up @@ -313,3 +315,127 @@ async fn mysql_floats_do_not_lose_precision(api: &TestApi) -> TestResult {

Ok(())
}

#[test_each_connector(tags("mysql"), log = "debug")]
async fn all_mysql_identifier_types_work(api: &TestApi) -> TestResult {
let identifier_types = &[
("tinyint", "12", ""),
("smallint", "350", ""),
("int", "9002", ""),
("bigint", "30000", ""),
("decimal(4, 2)", "3.1", ""),
// ("float", "2.8", ""),
("double", "0.1", ""),
("real", "12.1", ""),
("bit(32)", "4", ""),
("boolean", "true", ""),
("date", "\"2020-02-27T00:00:00.000Z\"", ""),
("datetime", "\"2020-02-27T19:10:22.000Z\"", ""),
("timestamp", "\"2020-02-27T19:11:22.000Z\"", ""),
// ("time", "\"1970-01-01T12:50:01.000Z\"", ""),
("year", "2091", ""),
("char(18)", "\"make dolphins easy\"", ""),
("varchar(200)", "\"dolphins of varying characters\"", ""),
("tinytext", "\"tiny dolphins\"", "(20)"),
("text", "\"dolphins\"", "(100)"),
("mediumtext", "\"medium dolphins\"", "(100)"),
("longtext", "\"long dolphins\"", "(100)"),
(
"enum('pollicle_dogs','jellicle_cats')",
"\"jellicle_cats\"",
"",
),
// ("json", "\"{\\\"name\\\": null}\"", ""),
];

let drop_table = r#"DROP TABLE IF EXISTS `pk_test`"#;

for (identifier_type, identifier_value, prefix) in identifier_types {
for index_type in &["PRIMARY KEY", "CONSTRAINT UNIQUE INDEX"] {
let create_pk_table = format!(
r#"CREATE TABLE `pk_test` (id {} NOT NULL, {} (id{}))"#,
identifier_type, index_type, prefix
);
api.execute_sql(drop_table).await?;
api.execute_sql(&create_pk_table).await?;

let (_datamodel, engine) = api.introspect_and_start_query_engine().await?;

let query = format!(
r#"
mutation {{
createOnepk_test(
data: {{
id: {}
}}
) {{
id
}}
}}
"#,
identifier_value
);

let response = engine.request(query).await;

let expected_response = format!(
r#"{{"data":{{"createOnepk_test":{{"id":{}}}}}}}"#,
identifier_value
);
assert_eq!(response.to_string(), expected_response);
}
}

Ok(())
}

#[test_each_connector(tags("mysql"), log = "debug")]
async fn all_mysql_types_work_as_filter(api: &TestApi) -> TestResult {
api.execute_sql(CREATE_TYPES_TABLE).await?;

let (_datamodel, engine) = api.introspect_and_start_query_engine().await?;

engine.request(CREATE_ONE_TYPES_QUERY).await;

let query = "
query {
findManytypes(
where: {
numeric_integer_tinyint: 12,
numeric_integer_smallint: 350,
numeric_integer_int: 9002,
numeric_integer_bigint: 30000,
numeric_floating_decimal: 3.14
# numeric_floating_float: -32.0
numeric_fixed_double: 0.14
numeric_fixed_real: 12.12
numeric_bit: 4
numeric_boolean: true
date_date: \"2020-02-27T00:00:00Z\"
date_datetime: \"2020-02-27T19:10:22Z\"
date_timestamp: \"2020-02-27T19:11:22Z\"
# date_time: \"2020-02-20T12:50:01Z\"
date_year: 2012
string_char: \"make dolphins easy\"
string_varchar: \"dolphins of varying characters\"
string_text_tinytext: \"tiny dolphins\"
string_text_text: \"dolphins\"
string_text_mediumtext: \"medium dolphins\"
string_text_longtext: \"long dolphins\"
string_enum: \"jellicle_cats\"
# json: \"{\\\"name\\\": null}\"
}
) {
id
}
}
";

let response = engine.request(query).await;

let expected_json = json!({ "data": { "findManytypes": [{ "id": 1 }] } });

assert_eq!(response, expected_json);

Ok(())
}
2 changes: 1 addition & 1 deletion query-engine/prisma/src/tests/type_mappings/postgres_types.rs
View file
Open in desktop
Expand Up @@ -497,7 +497,7 @@ async fn all_postgres_id_types_work(api: &TestApi) -> TestResult {
("boolean", "true"),
("inet", "\"127.0.0.4\""),
// ("json", "\"{ \\\"isThisPrimaryKeyReallyJSON\\\": true }\""),
// ("jsonb", "\"{ \\\"isThisPrimaryKeyReallyJSON\\\": true }\""),
("jsonb", "\"{\\\"isThisPrimaryKeyReallyJSON\\\":true}\""),
];

let drop_table = r#"DROP TABLE IF EXISTS "prisma-tests"."pk_test""#;
Expand Down
4 changes: 4 additions & 0 deletions query-engine/prisma/src/tests/type_mappings/test_api.rs
View file
Open in desktop
Expand Up @@ -12,6 +12,10 @@ pub struct TestApi {
}

impl TestApi {
pub fn connection(&self) -> &Quaint {
&self.connection
}

fn datasource(&self) -> String {
format!(
r#"
Expand Down