Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten Version Check Part 2 #795

Merged
merged 10 commits into from Jun 11, 2020
Merged

Tighten Version Check Part 2 #795

merged 10 commits into from Jun 11, 2020

Conversation

do4gr
Copy link
Member

@do4gr do4gr commented Jun 9, 2020 •
edited

  • add check for usage of default values
  • add check for length of string fields
  • empty data models are identified as NonPrisma now
  • introduce new error for inconsistent sql schema

Fixes prisma/prisma#2688
Fixes prisma/prisma#1057

@do4gr
dry up code,
bf4a93b 
add check for usage of default values
@do4gr do4gr added this to the Beta 10 milestone Jun 9, 2020
@do4gr do4gr self-assigned this Jun 9, 2020
@do4gr
add reqwest for private testtool,
b71fce6 
tighten version check using string lengths
@do4gr
add test
bb2c19a
@do4gr do4gr modified the milestones: Beta 10, 2.1.0 Jun 10, 2020
tomhoule
tomhoule approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering about the reqwest dependency, because it's going to be compiled everytime we cargo test. Could it go in the same stash as the urls?

the rest is all lgtm!

introspection-engine/connectors/sql-introspection-connector/src/version_checker.rs Show resolved Hide resolved
@do4gr do4gr changed the title [WIP] Tighten Version Check Part 2 Tighten Version Check Part 2 Jun 11, 2020
@do4gr do4gr merged commit e172ae2 into master Jun 11, 2020
@do4gr do4gr deleted the TightenVersionToolPart2 branch June 11, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule tomhoule approved these changes

Assignees

@do4gr do4gr

Labels
None yet
Projects
None yet
Milestone
2.1.0
2 participants
@do4gr @tomhoule