Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sqlite: for defining a sqlite url #11468

Closed
Jolg42 opened this issue Jan 28, 2022 · 1 comment · Fixed by prisma/prisma-engines#2948
Closed

Remove sqlite: for defining a sqlite url #11468

Jolg42 opened this issue Jan 28, 2022 · 1 comment · Fixed by prisma/prisma-engines#2948
Assignees
@pimeys
Labels
kind/tech A technical change. team/client Issue for team Client. team/schema Issue for team Schema. tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. topic: breaking change topic: connection-url topic: prisma4 topic: sqlite topic: tech debt Initiatives to improve the experience of working with the code base
Milestone
4.0.0

Comments

@Jolg42
Copy link
Member

Jolg42 commented Jan 28, 2022

For legacy reasons it was a thing (with Prisma 2 alpha maybe?)

see code mentioning it
https://sourcegraph.com/search?q=context:global+repo:github.com/prisma/+%28%27%7C%22%29sqlite:&patternType=regexp

Though it's not documented at all anywhere, see
https://www.prisma.io/docs/concepts/database-connectors/sqlite

It might be partly untested and could be a good candidate for a cleanup/removal to simplify.

Note that the current official url definition for a SQLite is file: in a Prisma Schema.
@Jolg42 Jolg42 added process/candidate topic: connection-url topic: sqlite tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. team/schema Issue for team Schema. team/client Issue for team Client. topic: tech debt Initiatives to improve the experience of working with the code base labels Jan 28, 2022
@Jolg42 Jolg42 mentioned this issue Jan 28, 2022
Merged
@janpio janpio added the kind/tech A technical change. label Jan 29, 2022
@floelhoeffel
Copy link

Idea: cleanup in prisma 4

@janpio janpio changed the title Investigate usage and potential removal of sqlite: for defining a sqlite url Remove sqlite: for defining a sqlite url May 9, 2022
@pimeys pimeys self-assigned this Jun 1, 2022
This was referenced Jun 1, 2022
Merged
Merged
@pimeys pimeys added this to the 4.0.x milestone Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pimeys pimeys

Labels
kind/tech A technical change. team/client Issue for team Client. team/schema Issue for team Schema. tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. topic: breaking change topic: connection-url topic: prisma4 topic: sqlite topic: tech debt Initiatives to improve the experience of working with the code base
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Only allow file: for SQLite URIs prisma/prisma-engines
4 participants
@pimeys @janpio @Jolg42 @floelhoeffel