Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate internal duration/performance logging #13693

Closed
janpio opened this issue Jun 8, 2022 · 1 comment · Fixed by prisma/prisma-engines#2995
Closed

Migrate internal duration/performance logging #13693

janpio opened this issue Jun 8, 2022 · 1 comment · Fixed by prisma/prisma-engines#2995
Assignees
Labels
Milestone

Comments

@janpio
Copy link
Member

janpio commented Jun 8, 2022

Issues like #13692 or #12384 are currently hard to understand and debug because we have no debug logging about how long the individual sub steps of Migrations CLI command take. We should add that, so we can ask users reporting such problems to enable it and report to us.

The goal is to already have a better understanding of what exactly is slow (is it one specific step? or are just all steps generally slow?) before going deeper into reproduction or fixing.

@tomhoule
Copy link
Contributor

tomhoule commented Jun 8, 2022

The migration engine already has a lot of instrumentation we use for debugging in tests. We've had for a long time tracing spans and events using the same tracing framework the query engine recently adopted. It could be as simple as figuring out a non-intrusive, nice way to expose timings for these spans. That would include how long each rpc request takes, as well as more granular spans inside each command.

@tomhoule tomhoule self-assigned this Jun 21, 2022
tomhoule added a commit to prisma/prisma-engines that referenced this issue Jun 21, 2022
This is a minimal tracing layer that times how long each span takes and
logs an event with the result after the span is closed, for our own
needs in performance observability.

closes prisma/prisma#13693
tomhoule added a commit to prisma/prisma-engines that referenced this issue Jun 21, 2022
This is a minimal tracing layer that times how long each span takes and
logs an event with the result after the span is closed, for our own
needs in performance observability.

closes prisma/prisma#13693
tomhoule added a commit to prisma/prisma-engines that referenced this issue Jun 21, 2022
This is a minimal tracing layer that times how long each span takes and
logs an event with the result after the span is closed, for our own
needs in performance observability.

closes prisma/prisma#13693
@janpio janpio added this to the 4.0.0 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants