Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate-cli: do not override RUST_LOG from the environment #13931

Closed
tomhoule opened this issue Jun 21, 2022 · 0 comments · Fixed by #14074
Closed

migrate-cli: do not override RUST_LOG from the environment #13931

tomhoule opened this issue Jun 21, 2022 · 0 comments · Fixed by #14074
Labels
kind/tech A technical change. team/schema Issue for team Schema. topic: cli topic: migrate topic: observability
Milestone
4.1.0

Comments

@tomhoule
Copy link
Contributor

We want to be able to control engines logging independently of CLI logging. Logs are not used for any business logic at present, so there is seemingly no valid reason to override RUST_LOG.
@Jolg42 Jolg42 added this to the 4.1.0 milestone Jun 30, 2022
Jolg42 added a commit that referenced this issue Jun 30, 2022
@Jolg42
fix(*): use process.env value or default for RUST_LOG RUST_BACKTRACE
2e14bad 
closes #13931
@Jolg42 Jolg42 mentioned this issue Jun 30, 2022
Merged
Jolg42 added a commit that referenced this issue Jul 18, 2022
@Jolg42
fix(*): use process.env value or default for RUST_LOG RUST_BACKTRACE (#…
f8b8d38 
…14074)

* fix(*): use process.env value or default for RUST_LOG RUST_BACKTRACE

closes #13931

* remove SERVER_ROOT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/tech A technical change. team/schema Issue for team Schema. topic: cli topic: migrate topic: observability
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

fix(*): use process.env value or default for RUST_LOG RUST_BACKTRACE prisma/prisma
3 participants
@Jolg42 @floelhoeffel @tomhoule