Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): use process.env value or default for RUST_LOG RUST_BACKTRACE #14074

Merged
merged 3 commits into from
Jul 18, 2022
Merged

fix(*): use process.env value or default for RUST_LOG RUST_BACKTRACE #14074

merged 3 commits into from
Jul 18, 2022

Conversation

Jolg42
Copy link
Member

@Jolg42 Jolg42 commented Jun 30, 2022

closes #13931

@Jolg42 Jolg42 added this to the 4.1.0 milestone Jun 30, 2022
@Jolg42 Jolg42 requested a review from tomhoule June 30, 2022 12:55
@Jolg42
Copy link
Member Author

Jolg42 commented Jun 30, 2022 •
edited

@tomhoule you can try this integration version 4.1.0-integration-env-rust-log.1 which includes changes from this PR

If you set RUST_LOG or RUST_BACKTRACE in your env it should now propagate

tomhoule
tomhoule approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

packages/migrate/src/MigrateEngine.ts Outdated Show resolved Hide resolved
@Jolg42 Jolg42 marked this pull request as ready for review July 6, 2022 12:09
@Jolg42 Jolg42 requested a review from a team July 6, 2022 12:10
@Jolg42 Jolg42 requested a review from jkomyno as a code owner July 6, 2022 12:10
@Jolg42 Jolg42 requested review from SevInf and removed request for a team July 6, 2022 12:10
@Jolg42 Jolg42 merged commit f8b8d38 into main Jul 18, 2022
@Jolg42 Jolg42 deleted the integration/env-RUST_LOG branch July 18, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevInf SevInf SevInf left review comments

@tomhoule tomhoule tomhoule approved these changes

@jkomyno jkomyno Awaiting requested review from jkomyno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

migrate-cli: do not override RUST_LOG from the environment
3 participants
@Jolg42 @SevInf @tomhoule