“Transaction API error: Transaction not found”

[heymartinadams]

Bug description

Context: I’m trying to implement Replicache using Prisma interactive transactions for an offline-first, instant UI. 🚀

Bug: While using transactions, I get a Transaction API error: Transaction not found error.

How to reproduce

1. Clone https://github.com/ConsciousApps/replicache-demo
2. Obtain PlanetScale database test password via instructions in README.md file and replace placeholder in .env file
3. Install: yarn (or npm install)
4. Reset database (in case I, or someone else, has already populated it with data): yarn db:reset
5. Run yarn dev
6. Sign up or sign in
7. Once signed in, create 5 new to-dos in quick succession (creating new to-dos slowly does not produce this bug)

Expected behavior

All transactions should be found.

Prisma information

Schema: https://github.com/ConsciousApps/replicache-demo/blob/main/prisma/schema.prisma

Prisma Transactions:
https://github.com/ConsciousApps/replicache-demo/blob/main/pages/api/replicache/push.js#L24-L59
https://github.com/ConsciousApps/replicache-demo/blob/main/pages/api/replicache/pull.js#L20-L61

(bug shows up in either files)

Environment & setup

• OS: macOS
• Database: PlanetScale MySQL
• Node.js version: 16.16.0

Prisma Version

4.6.0-dev.32 (latest)

[janpio]

One nice aspect to exclude here would be PlanetScale databases and referentialIntegrity = "prisma". Can you maybe run your reproduction against a normal MySQL and confirm that this is also happening there? Thanks.

[heymartinadams]

Found what caused it. Transaction not found error went away once I removed this:

} catch (err) {
  console.error(err)
  res.status(500).send(err.toString())
} finally {
  await prisma.$disconnect()
}

onetask-me/prisma-replicache-demo@734f9ed#diff-b5c776daef6284d72036715b72e4d5ff18cc0558dea8a0742f6c859e6f0f12b8L62-L68

[janpio]

We should try to figure out what is going on here.

[heymartinadams]

@janpio the repo is a complete demo/reproduction so hopefully should be easy to set up and figure out.

[heymartinadams]

Hey @aqrln, I noticed you signed on yesterday... revisiting this repo today as well. Seems like there are a few bugs related to Replicache, I’ll see if I can work them out first and will let you know once I have.

[aqrln]

Hey @heymartinadams no worries, I already finished the investigation and was going to share an update with you tomorrow. The gist is the issue was triggered by calling $disconnect inside the finally clause of the try/catch block — i.e., every time after every single transaction regardless of whether succeeded or errored, which broke other concurrently running transactions as the disconnect actually happened. I was going to call this a bug and say that $disconnect should wait for the transactions to complete, but then I realised it has some implications in edge cases, so we will have to think about which behaviour should be considered correct together with the team.

I assume you actually meant to put the $disconnect into the catch clause and only put it into the finally clause by accident, but either way I’m curious what is the purpose of that? I would expect it to be redundant or even lead to performance issues due to re-establishing the database connection. Have you run into any issues where Prisma doesn’t properly recover from errors?

[heymartinadams]

Hi @aqrln, I didn’t know what I was doing regarding the $disconnect, so it’s more of a case of me having put this there without understanding it properly 🤦🏻‍♂ Is the Prisma tx, the way it’s written without $disconnect, correct?

So I finally figured out how to make it work, yay! 🎉 Looking forward to implementing it, and, once implemented, would love to connect with someone at Prisma to write up a blog post about it! Offline / undo-redo / and instant UI are definitely features in high demand and I think a blog post could add tremendous value to many devs. Please let me know!

CleanShot.2022-11-18.at.09.52.44.mp4

[aqrln]

Hi @heymartinadams and sorry for the late reply!

Looking forward to implementing it, and, once implemented, would love to connect with someone at Prisma to write up a blog post about it! Offline / undo-redo / and instant UI are definitely features in high demand and I think a blog post could add tremendous value to many devs. Please let me know!

Thank you, I passed your message to the team!

Is the Prisma tx, the way it’s written without $disconnect, correct?

Yep, I didn't look into what happens inside the transaction itself in details, so I can't give much additional advice, but in the context of this issue just removing the $disconnect should be good! You can leave the try/catch block if you need it for any other reason, no need to remove it like in onetask-me/prisma-replicache-demo@734f9ed, just remove the await prisma.$disconnect() line.

In prisma/prisma-engines#3391 I changed the error message from just Transaction not found to Transaction not found. Transaction ID is invalid, refers to an old closed transaction Prisma doesn't have information about anymore, or was obtained before disconnecting. Would that have been helpful in figuring out what happened and fixing the issue if the error message looked like that when you encountered it?

[aqrln]

I'm going to go ahead and close this issue since it has been resolved. Feel free to leave a comment or open a new issue if you think there is still something missing on our side.

We also have ideas for improvements of $disconnect behaviour to try to prevent mistakes like this — new GitHub issue(s) will be opened for that.

[heymartinadams]

Thank you @aqrln ✨ A more detailed error message might have been helpful at the time. Glad it’s made its way into 4.7.0.

I’ll write up a blog post about Replicache shortly. https://github.com/simplerlist/replicache-demo

[aruns05]

Hello @aqrln Is any fix found for this ? I am facing same issue

[janpio]

This issue is closed, so we do not think there is a problem any more. If something is not working for you @aruns05, please open a new issue. Thanks.