qe: improve error messages for closed transactions #3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqrln
changed the title
aqrln
force-pushed
the
integration/closed-itx-error-message
branch
2 times, most recently
from
8eb3e1d
to
a0f321d
Compare
aqrln
force-pushed
the
integration/closed-itx-error-message
branch
from
d97372b
to
a3aebd9
Compare
aqrln
added a commit
to prisma/prisma
that referenced
this pull request
Nov 21, 2022
miguelff
approved these changes
Nov 21, 2022
|
Some tests fail because they expect a different error message. Other than that, the changes look correct. |
aqrln
added a commit
to prisma/prisma
that referenced
this pull request
Nov 21, 2022
aqrln
added a commit
to prisma/prisma
that referenced
this pull request
Nov 23, 2022
jkomyno
pushed a commit
to prisma/prisma
that referenced
this pull request
Dec 21, 2022
jkomyno
pushed a commit
to prisma/prisma
that referenced
this pull request
Dec 21, 2022
|
In production I get And it's a useless error message and going straight into my logs, I have no context here. |
|
The lack of |
|
Please open an issue over at https://github.com/prisma/prisma instead of commenting on a 11 months old, merged PR. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the error messages for closed transactions more detailed, add extra context about the transaction timeout.
Before:
Transaction API error: Transaction already closed: A query/commit/rollback cannot be executed on a closed transaction..(also note the double "." at the end)
Now:
Transaction API error: Transaction already closed: A query/commit/rollback cannot be executed on a committed transaction.Transaction API error: Transaction already closed: A query/commit/rollback cannot be executed on a transaction that was rolled back.Transaction API error: Transaction already closed: A query/commit/rollback cannot be executed on an expired transaction. The timeout for this transaction was X ms, however Y ms passed since the start of the transaction. Consider increasing the interactive transaction timeout or doing less work in the transaction.Additionally, the "Transaction not found error" is now also more verbose, ref: https://www.notion.so/disconnect-with-iTX-f3cfee3ff4924e40aa90aadb2454e9fa?d=3bd7c7103b02461bbfe414a978a994c1#547ab127682b41898c87bdd5c841c0bf
This PR also contains minor cleanup things related to iTX I did along the way, I'm happy to move them to separate tiny PRs to reduce scope of this PR if you'd like:
CachedTx::Abortedvariant.envrcClient PR: prisma/prisma#16382
Closes: prisma/prisma#13713
Ref: prisma/prisma#16050
Ref: #3028