Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relationMode: make feature GA #16224

Closed
4 tasks done
Jolg42 opened this issue Nov 10, 2022 · 0 comments
Closed
4 tasks done

relationMode: make feature GA #16224

Jolg42 opened this issue Nov 10, 2022 · 0 comments
Assignees
@Jolg42
Labels
kind/tech A technical change. team/schema Issue for team Schema. tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. topic: referentialIntegrity/relationMode
Milestone
4.7.0

Comments

@Jolg42
Copy link
Member

Jolg42 commented Nov 10, 2022 •
edited

We are planning to make the feature GA

We need to

  • mark the previewFeature flag referentialIntegrity as not needed anymore
  • make the feature GA (it should not need a flag anymore)
  • have tests in prisma/prisma without the preview feature (remove preview feature from tests)
  • have tests in prisma/prisma-engines without the preview feature (remove preview feature from tests)

For language-tools see issue prisma/language-tools#1282
@Jolg42 Jolg42 added kind/tech A technical change. team/schema Issue for team Schema. topic: referentialIntegrity/relationMode tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. labels Nov 10, 2022
@Jolg42 Jolg42 added this to the 4.7.0 milestone Nov 10, 2022
@Jolg42 Jolg42 mentioned this issue Nov 21, 2022
Merged
@Jolg42 Jolg42 self-assigned this Nov 22, 2022
@Jolg42 Jolg42 mentioned this issue Nov 22, 2022
Merged
Jolg42 added a commit that referenced this issue Nov 22, 2022
@Jolg42
test: remove referentialIntegrity flag
0526c63 
Waiting for prisma/prisma-engines#3428 to be merged first.

Related #16224
@Jolg42 Jolg42 mentioned this issue Nov 22, 2022
Merged
@Jolg42 Jolg42 closed this as completed Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jolg42 Jolg42

Labels
kind/tech A technical change. team/schema Issue for team Schema. tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. topic: referentialIntegrity/relationMode
Projects
None yet
Milestone
4.7.0
Development

No branches or pull requests
1 participant
@Jolg42