[Prisma Client] Duplicate identifier with models "X" and "XClient"

[dodas]

Consider following datamodel:

model Company {
   ...
}

model CompanyClient {
   ...
}

Prisma seem to generate class for each model, with Client appended to its name:

// this is corresponding to model "Company"
export declare class CompanyClient<T> implements Promise<T> {
  ...
}

//  this is corresponding to model "CompanyClient"
export declare class CompanyClientClient<T> implements Promise<T> {
  ...
}

..but it also generates type for each model, without appending anything to its name:

export type Company = {
   ...
} 

export type CompanyClient = {
   ...
} 

This leads to typescript error, as type CompanyClient is clashing with class CompanyClient:

Duplicate identifier 'CompanyClient'. ts(2300)

Naming convention for "Client" classes should be altered, probably..

---

Prisma CLI / client version: 2.0.0-beta.5

[pantharshit00]

I can confirm this bug. Thanks for reporting!

I also think we not add this case to the deny list as this naming pattern seems a bit common.

[Jolg42]

It looks like it is already in the denylist. I will double check.

prisma/src/packages/client/src/generation/generateClient.ts

Line 561 in ebe1b08

`${m.name}Client`,

[Jolg42]

Thank you for the issue, the "denylist" is now applied to model names as well with tests.

You probably want to rename your models to avoid a conflict here, one solution could be to use @@map:
https://www.prisma.io/docs/reference/tools-and-interfaces/prisma-client/configuring-the-prisma-client-api#using-map-and-map-to-rename-fields-and-models-in-the-prisma-client-api

[dodas]

Does that mean that issue is fixed and I can keep current model names after eventual prisma release?
Thanks!

[Jolg42]

@dodas So no it means that out internal list of reserved word just got updated and it will error properly now if you retry with the latest alpha.

So you will need to change the names of your models. And if you already have these models in your database you could use @@map to keep them and only change the names for the Prisma Client / Schema.

[dodas]

That's unfortunate solution...
I think that naming models ,,SomethingClient" can be quite common and having to rename model that corresponds to business domain is not nice thing to do.
Couldn't the ,,Client" classes be named differently instead? Perhaps in a way that they could never clash with data model names?
Or maybe they can be defined in different file and prevent duplicate identifiers that way?

[Jolg42]

I understand the problem here and I'm also in favor of finding a better solution 👍
The best would be to open an issue, could you do that?

[pantharshit00]

I propose prefixing our implementation with internal. I don't know if this will be a breaking change or not:
${name}InternalClient

Generally we should prefix out implementation. What are your thoughts @Jolg42 ?

[pantharshit00]

I opened: prisma/prisma-client-js#707