Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client,cli): apply dynamic denylist for models with tests #2589

Merged
merged 3 commits into from May 28, 2020
Merged

fix(client,cli): apply dynamic denylist for models with tests #2589

merged 3 commits into from May 28, 2020

Conversation

Jolg42
Copy link
Member

@Jolg42 Jolg42 commented May 28, 2020 •
edited

Closes #2539

  • models are now checked against the dynamic denylist
  • added tests for errors from engine & client validation
  • generator was doing console.error and I changed that to throw new DenylistError

@Jolg42 Jolg42 added this to the Beta 7 milestone May 28, 2020
@Jolg42 Jolg42 requested a review from timsuchanek May 28, 2020 11:04
@Jolg42 Jolg42 merged commit e704e6d into master May 28, 2020
@Jolg42 Jolg42 deleted the pr/dynamic-denylist-models branch May 28, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsuchanek timsuchanek timsuchanek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Beta 7
Development

Successfully merging this pull request may close these issues.

[Prisma Client] Duplicate identifier with models "X" and "XClient"
2 participants
@Jolg42 @timsuchanek