Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten Version Check for P1 and P1.1 further #2688

Closed
do4gr opened this issue Jun 8, 2020 · 0 comments · Fixed by prisma/prisma-engines#795
Closed

Tighten Version Check for P1 and P1.1 further #2688

do4gr opened this issue Jun 8, 2020 · 0 comments · Fixed by prisma/prisma-engines#795
Labels
kind/improvement An improvement to existing feature and code. tech/engines Issue for tech Engines. topic: introspection
Milestone
2.1.0

Comments

@do4gr
Copy link
Member

do4gr commented Jun 8, 2020

Use the fact that P1 and P1.1 only used very specific length limitations on char and varchar columns.
Use the fact that P1 and P1.1 never used database level default values.
@pantharshit00 pantharshit00 added kind/improvement An improvement to existing feature and code. topic: introspection labels Jun 8, 2020
@do4gr do4gr mentioned this issue Jun 9, 2020
Merged
@janpio janpio added this to the 2.1.0 milestone Jun 10, 2020
@janpio janpio added the tech/engines Issue for tech Engines. label Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement An improvement to existing feature and code. tech/engines Issue for tech Engines. topic: introspection
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Tighten Version Check Part 2 prisma/prisma-engines
3 participants
@janpio @do4gr @pantharshit00