prisma generate fails when using pnpm workspaces because it tries to install prisma dependencies with npm or yarn

[keyworks]

Bug description

prisma migrate dev appears to be running npm to install @prisma/cli but it fails since my project is a pnpm project.

How to reproduce

1. Set up your repo to use pnpm workspaces and workspace: protocol in package.json (see https://pnpm.js.org/en/workspaces)
2. Write a schema.
3. Run the initial migration: pnpx prisma migrate dev --name init --preview-feature

I get the following error:

myapp (master *) $ pnpx prisma migrate dev --name init --preview-feature
Prisma schema loaded from prisma/schema.prisma
Datasource "db": SQLite database "dev.db" at "file:./dev.db"

SQLite database dev.db created at file:./dev.db

The following migration(s) have been created and applied from new schema changes:

migrations/
  └─ 20210129014823_init/
    └─ migration.sql

Running generate... (Use --skip-generate to skip the generators)
npm ERR! code EUNSUPPORTEDPROTOCOL
npm ERR! Unsupported URL Type "workspace:": workspace:^0.4.0

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/jkim/.npm/_logs/2021-01-29T01_48_26_656Z-debug.log
Error: Command failed with exit code 1: npm install -D @prisma/cli@2.15.0

Expected behavior

No error

Environment & setup

• OS: MacOS
• Database: SQLite
• Node.js version: v10.22.0
• Prisma version: 2.15.0

[keyworks]

Actually I just got past the issue by just manual installing @prisma/client in my local project. I ran: pnpm add @prisma/client.

[pantharshit00]

Looks like we always use npm to install the client package if it is missing. Workaround should suffice here for now but we should recheck this assumption in code.

[pantharshit00]

This is still reproducible, we should add a special case for pnpm

[PabloSzx]

@keyworks could you confirm this issue is fixed using these versions of prisma?

I personally tested in a couple projects and everything seems to work correctly now

"prisma": "2.27.0-integration-fix-sdk-pnpm.1",
"@prisma/client": "2.27.0-integration-fix-sdk-pnpm.1",

[gaggle]

(BTW if the context is of interest I described this fix in my article-series exploring TS monorepo patterns: https://dev.to/jonlauridsen/attempt-3-build-the-source-4oa3)

[v-morlock]

We are experiencing the same issue using yarn 2, even when using 2.27.0-integration-fix-sdk-pnpm.2

[Jolg42]

I think what's happening here is that when your project doesn't have prisma or @prisma/client dependencies installed.
In that case the prisma-client-js will try to install it using npm or yarn and then fail.

Current workaround:

• Use any version of Prisma (latest recommended)
• pnpm add @prisma/client
• pnpm add -D prisma

We need to add pnpm support here:
https://github.com/prisma/prisma/blob/ea886f84f2f7923eb93533092cd82be7d4af99aa/packages/sdk/src/predefinedGeneratorResolvers.ts

[v-morlock]

Actually we are using the exact same setup as before - on 2.23.0, everything has been working just fine, on 2.29.0, we are getting the npm-error. We use prisma within a workspace of a yarn2-monorepo.

our new dependencies look like this:

    "@prisma/client": "^2.29.0",
    "prisma": "^2.29.0",

[Jolg42]

@v-morlock It would be good to open a seperate issue for Yarn 2 since it might be a different, but maybe related problem.
This issue is specific to pnpm.

[ankhzet]

@millsp

So the idea is to override this logic if we find existing lock files

Wouldn't work in some cases, f.e. in rushjs monorepo lock files are kept in a separate subdirectory. Probably better way would be to explicitly state used package manager (f.e. "prisma.packageManager" field in package.json) or to handle this special usecase separately (maybe, search for rush.json in parent directories, but this would add more complexity to the logic and more maintenance burden). Otherwise migrate script errors out with npm ERR! code EUNSUPPORTEDPROTOCOL even if pnpx was used to run the command.

For now manually installing @prisma/client beforehand allows to circumvent the problem.

[pilchard]

This isn't monorepo specific, just pnpm. I have just walked through the Quickstart with pnpm in a clean directory and encountered this. I don't mind (would rather) install dependencies manually but it isn't mentioned anywhere on that page (though it does indicate ts-node). Installing @prisma/client manually was all that was needed. I just needed to mock up a quick sqlite example and it's annoying to be commenting on an issue midway through the Quickstart instead.

[savager]

Is there a specific version I can install to avoid this currently? I don't want to move away from pnpm monorepo at the moment.

[millsp]

We are going to prioritize this issue in the coming weeks. For now, the workaround is to manually add @prisma/client as a dependency.

[savager]

Adding @prisma/client to the root repo's dependencies did solve the issue. Thanks much!

[millsp]

Hey folks, we have just improved our pnpm detection logic to fix this issue, and we will release this in our 4.13.0 release. That said, you can try it now by installing our dev version. npm install prisma@dev. Feedback welcome!