Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client, cli): client auto-install for pnpm #18646

Merged
merged 31 commits into from Apr 14, 2023

Conversation

millsp
Copy link
Member

@millsp millsp commented Apr 6, 2023

Fixes #5340
Fixes #9848
Fixes #14944
Fixes #11791
Fixes #14401
Fixes #14816
Fixes #18238
...likely to close yarn issues, but more tests are needed

Do not spend too much time on reviewing @prisma/ni, this package is temporary and is a port of my PR antfu-collective/ni#151 until it gets merged. You can review that PR too, if you find it useful.

For the reviewer, please also review prisma/ecosystem-tests#3469

@millsp millsp added this to the 4.13.0 milestone Apr 6, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 6, 2023

CodSpeed Performance Report

Merging #18646 integration/fix/use-ni-pm-detection (1ad0d34) will not alter performances.

Summary

🔥 1 improvements
❌ 0 regressions
✅ 2 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

Benchmarks breakdown

Benchmark main integration/fix/use-ni-pm-detection Change
🔥 typescript compilation ~50 Models 644.4 ms 47.5 ms 92.63%

@socket-security
Copy link

socket-security bot commented Apr 12, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Ignoring: esbuild@0.17.16, esbuild@0.17.5

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
which@3.0.0 None +0 lukekarrys
esno@0.16.3 eval, network, filesystem, shell, environment +6 antfu
ini@4.0.0 None +0 gar
@types/ini@1.3.31 None +0 types
fzf@0.5.1 None +0 ajitid
@posva/prompts@2.4.4 None +1 posva
terminal-link@3.0.0 None +2 sindresorhus
find-up@6.3.0 None +5 sindresorhus
@types/which@3.0.0 None +0 types
kleur@4.1.5 None +0 lukeed
@types/fs-extra@11.0.1 None +1 types
eslint@8.38.0 filesystem, environment +2 eslintbot

@millsp
Copy link
Member Author

millsp commented Apr 12, 2023

@SocketSecurity ignore

@millsp millsp marked this pull request as ready for review April 14, 2023 03:58
@millsp millsp requested a review from a team April 14, 2023 03:58
@millsp millsp requested review from SevInf and removed request for a team April 14, 2023 03:58
@millsp millsp changed the title fix(cli): client auto-install fix(client, cli): client auto-install Apr 14, 2023
@millsp millsp changed the title fix(client, cli): client auto-install fix(client, cli): client auto-install for pnpm Apr 14, 2023
Copy link
Contributor

@SevInf SevInf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question and pointed out one potential problem, otherwise LGTM

packages/ni/README.md Outdated Show resolved Hide resolved
@millsp millsp merged commit d452662 into main Apr 14, 2023
57 checks passed
@millsp millsp deleted the integration/fix/use-ni-pm-detection branch April 14, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment