Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prisma should check for generator binaries in $PATH #934

Closed
steebchen opened this issue Nov 13, 2019 · 2 comments
Closed

Prisma should check for generator binaries in $PATH #934

steebchen opened this issue Nov 13, 2019 · 2 comments
Labels
kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: generator
Milestone

Comments

@steebchen
Copy link
Contributor

When writing custom generators, you can specify an absolute or relative binary path for the "provider" value. However, the path resolution does not respect binaries in $PATH, which would make things easier for custom generators, because they can depend on globally installed binaries.

The following generator configuration does not work:

generator photon {
	provider = "photongo"
	output = "./photon/photon_gen.go"
	package = "photon"
}

image (1)

@pantharshit00 pantharshit00 added bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. labels Nov 14, 2019
@timsuchanek timsuchanek added kind/improvement An improvement to existing feature and code. and removed bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. labels Nov 15, 2019
@matthewmueller

This comment has been minimized.

@janpio

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: generator
Projects
None yet
Development

No branches or pull requests

5 participants