Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): rethrow error for tx #10797

Merged
merged 17 commits into from
Jan 31, 2022
Merged

fix(client): rethrow error for tx #10797

merged 17 commits into from
Jan 31, 2022

Conversation

millsp
Copy link
Member

@millsp millsp commented Dec 21, 2021

Fixes #9533
Fixes #10218
Fixes #10622

Adds more tests for postgres.

SET FOR RELEASE 3.9.0

@millsp millsp added this to the 3.9.0 milestone Jan 11, 2022
@millsp millsp marked this pull request as ready for review January 11, 2022 13:14
@millsp
Copy link
Member Author

millsp commented Jan 11, 2022

Failure does not seem related but rather flaky (macOS).

@millsp millsp changed the title fix(client): rethrow error for tx HOLD fix(client): rethrow error for tx Jan 11, 2022
@millsp millsp changed the title HOLD fix(client): rethrow error for tx fix(client): rethrow error for tx Jan 11, 2022
Copy link
Contributor

@garrensmith garrensmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix

@millsp millsp linked an issue Jan 12, 2022 that may be closed by this pull request
@millsp
Copy link
Member Author

millsp commented Jan 28, 2022

Needs prisma/prisma-engines#2619 to be merged on master then tests will pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants