Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(client): add test for integer overflow error #13331

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented May 12, 2022

@aqrln aqrln marked this pull request as draft May 12, 2022 16:23
@aqrln aqrln added this to the 3.15.0 milestone May 12, 2022
@aqrln aqrln changed the title chore: bump engines to 3.15.0-4.query-engine-number-input-e72daf8c81f55714a1179a513d80c46e0edc5cc7 chore: integrate integer parsing error May 31, 2022
@millsp
Copy link
Member

millsp commented May 31, 2022

If you have some time, can you please look into fixing this error that only happens on integration versions?

@SevInf
Copy link
Contributor

SevInf commented May 31, 2022

@millsp @aqrln I stumbled upon the same error in another branch, i believe the fix is quite simple

@aqrln aqrln changed the title chore: integrate integer parsing error test(client): add test for integer overflow error Jun 2, 2022
@aqrln aqrln marked this pull request as ready for review June 2, 2022 11:27
@aqrln aqrln merged commit a1c37ba into main Jun 8, 2022
@aqrln aqrln deleted the engine-number-input branch June 8, 2022 18:05
@Jolg42 Jolg42 modified the milestones: 3.15.0, 4.0.x Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants