Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: added support for additional cockroachdb tests #13537

Merged
merged 7 commits into from Jun 5, 2022

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented May 28, 2022

This PR adds cockroachdb tests for:

  • db execute
  • migrate dev
  • migrate diff

Closes #13268

@jkomyno
Copy link
Contributor Author

jkomyno commented May 28, 2022

Note: merging #13547 is necessary to make this PR's MacOS tests succeed.

@jkomyno jkomyno added this to the 3.15.0 milestone May 30, 2022
@jkomyno jkomyno marked this pull request as ready for review May 30, 2022 09:07
@jkomyno jkomyno requested a review from janpio May 30, 2022 09:07
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, and tests seem to be passing.

(Some actual TS developer should review besides me before merge though)

Also see questions and comments.

Copy link
Contributor

@pimeys pimeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. More tests are better than no tests, especially if they're green. Code quality looks decent to me.

@jkomyno jkomyno force-pushed the chore/additional-cockroachdb-tests branch from 0941d34 to cda37d5 Compare June 4, 2022 16:17
@jkomyno jkomyno merged commit 6ba097f into main Jun 5, 2022
@jkomyno jkomyno deleted the chore/additional-cockroachdb-tests branch June 5, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more integration tests for CockroachDB for db and migrate commands
4 participants