Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): rename @prisma/sdk to @prisma/internals #13868

Merged
merged 7 commits into from
Jun 20, 2022
Merged

chore(sdk): rename @prisma/sdk to @prisma/internals #13868

merged 7 commits into from
Jun 20, 2022

Conversation

Jolg42
Copy link
Member

@Jolg42 Jolg42 commented Jun 17, 2022

Related #10725

TODO rename directory and remaining mentions in next PR

@Jolg42 Jolg42 requested a review from a team June 17, 2022 09:36
@Jolg42 Jolg42 requested a review from jkomyno as a code owner June 17, 2022 09:36
@Jolg42 Jolg42 requested review from danstarns and removed request for a team June 17, 2022 09:36
@Jolg42 Jolg42 marked this pull request as draft June 17, 2022 09:39
@Jolg42 Jolg42 changed the title Automatically generated PR chore(sdk): rename @prisma/sdk to @prisma/internals Jun 17, 2022
@Jolg42 Jolg42 added this to the 4.0.x milestone Jun 17, 2022
@danstarns
Copy link
Contributor

Will the /packages/sdk/ directory also be reanamed?

@Jolg42
Copy link
Member Author

Jolg42 commented Jun 17, 2022

@danstarns Yes though I think it might be better to do that in another PR after we see things working

Jolg42 added a commit that referenced this pull request Jun 17, 2022
Jolg42 added a commit that referenced this pull request Jun 17, 2022
* ci(sdk): start publishing `@prisma/internals`

To unblock #13868

Related #10725

* fix: add `--access public`

Tells the registry that the published package should be public

(cherry picked from commit e3d0098)

* fix script

* fix script 2

(cherry picked from commit a0265b6)
@Jolg42
Copy link
Member Author

Jolg42 commented Jun 17, 2022

Fails with
https://github.com/prisma/prisma/runs/6936005555?check_suite_focus=true#step:6:913

Error: : packages/cli build: ✘ [ERROR] Could not resolve "@prisma/sdk"
. build: packages/cli build:     ../../node_modules/.pnpm/@prisma+studio-pcw@0.463.0_@prisma+client@packages+client/node_modules/@prisma/studio-pcw/dist/index.es.js:2:198:
. build: packages/cli build:       2 │ ...tryLoadEnvs, getEnvPaths as $aWMXZ$getEnvPaths} from "@prisma/sdk";
. build: packages/cli build:         ╵                                                         ~~~~~~~~~~~~~
. build: packages/cli build:   You can mark the path "@prisma/sdk" as external to exclude it from the bundle, which will remove this error.
Error: : packages/cli build: ✘ [ERROR] [plugin cliLifecyclePlugin] ENOENT: no such file or directory, stat './build/index.js'

Will be unblocked after https://github.com/prisma/studio-code/pull/403 is merged

packages/cli/package.json Outdated Show resolved Hide resolved
@Jolg42 Jolg42 marked this pull request as ready for review June 20, 2022 09:24
Copy link
Contributor

@jkomyno jkomyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine overall, but please double-check my comments

packages/client/jest.config.js Show resolved Hide resolved
packages/integration-tests/jest.config.js Show resolved Hide resolved
packages/migrate/jest.config.js Show resolved Hide resolved
packages/migrate/package.json Show resolved Hide resolved
tsconfig.build.bundle.json Show resolved Hide resolved
@Jolg42 Jolg42 merged commit 9e5cc5b into main Jun 20, 2022
@Jolg42 Jolg42 deleted the autopr/test1 branch June 20, 2022 11:59
Jolg42 added a commit that referenced this pull request Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants