-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prisma --version (#13737) #14053
Conversation
…ration/fix-version-pkg
Most likely, an invocation of these lines from inside export async function getEngineVersion(enginePath?: string, binaryName?: BinaryType): Promise<string> {
if (!binaryName) {
binaryName = getCliQueryEngineBinaryType()
}
// >>> from here:
enginePath = await resolveBinary(binaryName, enginePath)
if (binaryName === BinaryType.libqueryEngine) {
await isNodeAPISupported()
const QE = load<NodeAPILibraryTypes.Library>(enginePath)
return `libquery-engine ${QE.version().commit}`
} else {
// ...
}
} The previous code in #13737 assumed that the engine version could be read in a logical This problem was solved by making sure we read a proper binary path (preferring the one retrieved from environment variables) before even attempting to read any version. |
…ma/prisma into integration/fix-version-pkg
Essentially, PR #13737 without breaking ecosystem-tests.
Closes #14014.