Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fetch-engine): Prevent macOS from killing node on engine update #14301

Merged
merged 1 commit into from
Jul 14, 2022
Merged

fix(fetch-engine): Prevent macOS from killing node on engine update #14301

merged 1 commit into from
Jul 14, 2022

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented Jul 14, 2022

Fix #14058

@SevInf SevInf requested review from a team and danstarns and removed request for a team July 14, 2022 12:55
@SevInf SevInf added this to the 4.1.0 milestone Jul 14, 2022
garrensmith
garrensmith approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@garrensmith garrensmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. I tested it locally.

@SevInf SevInf merged commit 2c6e6e2 into main Jul 14, 2022
@SevInf SevInf deleted the fix/osx-gatekeeper branch July 14, 2022 16:25
@aqrln aqrln mentioned this pull request Jul 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrensmith garrensmith garrensmith approved these changes

@Jolg42 Jolg42 Awaiting requested review from Jolg42

@jkomyno jkomyno Awaiting requested review from jkomyno

@danstarns danstarns Awaiting requested review from danstarns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

macOS 12 sometimes kills Node.js process when loading the QE library
2 participants
@SevInf @garrensmith